[CH-5425] Add temporary logging for apns request #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froodian
reviewed
Mar 11, 2024
There was a problem hiding this comment.
rather than merge into this live-activity-revized branch, I think it might be cleaner to point the service at this push-to-start-test branch temporarily instead, so that sideshow#219 isn't impacted
edit: having read the apns-push-service pull, I think you've basically already done this, and this pull was useful for review but will eventually be closable without merge 👍
zijinlibraze
force-pushed
the
push-to-start-test
branch
from
167e30b
to
fa25f4c
Compare
jerielng
approved these changes
Mar 11, 2024
|
Testing done. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This change will NOT be merged.
We will simply have
apns-push-servicetemporarily use this branch to log the request and test for a day.The PR is just for people to check if these code will log things correctly.