Send: Fix double-lockup when payment is TimedOut #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Oct 29, 2024
roeierez
requested changes
Oct 29, 2024
roeierez
requested changes
Oct 31, 2024
hydra-yse
force-pushed
the
yse-double-lockup-fix
branch
from
131e5bf
to
21c50d3
Compare
roeierez
approved these changes
Oct 31, 2024
ok300
reviewed
Oct 31, 2024
ok300
approved these changes
Oct 31, 2024
roeierez
added a commit
that referenced
this pull request
Nov 5, 2024
* commit 'a515718dc72c1c8eb62cecb7ad9c9862e8dc727c': feat: allow send transition from `TimedOut` to `Created` (#545) Propagate signer interface changes (#544) fix: double-lockup when payment is TimedOut (#541) Reserved address pool (#531) Prevent swap double claim (#542) Receive Chain Swap: support refund even when lockup address is re-used (#471) Bring remaining u32 amount types to u64 (#537) Add swift framework plists (#536) Update README.md Update README.md Update roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the current event loop, TimedOut payments may cause lockups to be broadcast.
This PR changes the send flow such that:
send_payment, the lockup is broadcasted within that same thread only if it hasn't been broadcasted beforehandTODO: Persistlockup_tx_idbeforehand to ensure we don't broadcast twice in case the client closes the application before the new state is saved