Skip to content

Commit

Permalink
Fix crash with --experimental_skyframe_prepare_analysis by acceptin…
Browse files Browse the repository at this point in the history
…g any `DetailedException`.

It is possible to get a `MissingInputFileException` if the file specified by `--platform_mappings` does not exist.

We apparently don't have any tests for `--experimental_skyframe_prepare_analysis`.

PiperOrigin-RevId: 414681532
  • Loading branch information
justinhorvitz authored and copybara-github committed Dec 7, 2021
1 parent f4db9ce commit 795eab3
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3037,8 +3037,8 @@ public PrepareAnalysisPhaseValue prepareAnalysisPhase(
e =
new InvalidConfigurationException(
"cannot load build configuration because of this cycle", Code.CYCLE);
} else if (e instanceof NoSuchThingException) {
e = new InvalidConfigurationException(((NoSuchThingException) e).getDetailedExitCode(), e);
} else if (e instanceof DetailedException) {
e = new InvalidConfigurationException(((DetailedException) e).getDetailedExitCode(), e);
}
if (e != null) {
Throwables.throwIfInstanceOf(e, InvalidConfigurationException.class);
Expand Down

0 comments on commit 795eab3

Please sign in to comment.