Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle required arguments in nested pydantic models #163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle required arguments in nested pydantic models #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ff862
Handle default arguments in nested models
Xallt Sep 15, 2024
e6e6993
Run ruff formatting
Xallt Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tyro/_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,6 +1166,8 @@ def _get_pydantic_v2_field_default(
) -> Tuple[Any, bool]:
"""Helper for getting the default instance for a Pydantic field."""

import pydantic

# Try grabbing default from parent instance.
if (
parent_default_instance not in MISSING_SINGLETONS
Expand All @@ -1183,7 +1185,10 @@ def _get_pydantic_v2_field_default(
)

if not field.is_required():
return field.get_default(call_default_factory=True), False
try:
return field.get_default(call_default_factory=True), False
except pydantic.ValidationError:
pass

# Otherwise, no default.
return MISSING_NONPROP, False
Loading