Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow subcommand_cli_from_dict to specify console_outputs #175

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Allow subcommand_cli_from_dict to specify console_outputs #175

merged 3 commits into from
Oct 11, 2024

Conversation

mirceamironenco
Copy link
Contributor

Ran into this issue while trying to torchrun an entrypoint which uses tyro.extras.subcommand_cli_from_dict.

My thinking is that the API should be as close as possible to tyro.cli?

brentyi
brentyi approved these changes Oct 11, 2024
View reviewed changes
Copy link
Owner

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks reasonable. Thanks @mirceamironenco!

@brentyi brentyi merged commit 34f3b14 into brentyi:main Oct 11, 2024
@brentyi brentyi mentioned this pull request Oct 11, 2024
Merged
@mirceamironenco mirceamironenco deleted the add-consoleoutqol-clifromdict branch October 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirceamironenco @brentyi