Support auto param generation logic, validation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettswift
force-pushed
the
feature/required_params
branch
from
4c48465
to
f0e38de
Compare
|
@john-shaskin @jsauter |
brettswift
force-pushed
the
feature/required_params
branch
from
f0e38de
to
de84bac
Compare
Cumulus supports parameter auto-generation. When you add a resource that expects a parameter, cumulus will by default add these in for you. In the case of Stacker, or other apps that might wrap cumulus, there is a use case of parameters being created on the template for you. To support this you can turn off "auto parameter generation" in the chain context. The behaviour here will not add parameters, but will validate those to give the consumer a more intelligent message than "resource 'ParamOne' not found". Example code to be used in your chain Step can be found in the test.
brettswift
force-pushed
the
feature/required_params
branch
from
de84bac
to
c1a27a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cumulus supports parameter auto-generation. When you add a resource
that expects a parameter, cumulus will by default add these in for you.
In the case of Stacker, or other apps that might wrap cumulus, there is
a use case of parameters being created on the template for you. To
support this you can turn off "auto parameter generation" in the chain
context.
The behaviour here will not add parameters, but will validate those to
give the consumer a more intelligent message than "resource 'ParamOne'
not found".
Example code to be used in your chain Step can be found in the test.