Fix naming for pipeline role and CodeBuild projects. Make physical na… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-shaskin
force-pushed
the
feature/unique-codepipeline-resource-names
branch
2 times, most recently
from
7568f0b
to
dc66529
Compare
…l naming unique across multiple stack instances.
john-shaskin
force-pushed
the
feature/unique-codepipeline-resource-names
branch
from
dc66529
to
3fdf25b
Compare
brettswift
reviewed
Oct 15, 2018
|
|
||
| policy_name = "CodeBuildPolicy%s" % chain_context.instance_name | ||
| role_name = "CodeBuildRole%s" % suffix | ||
| policy_name = "%sCodeBuildPolicy" % chain_context.instance_name |
There was a problem hiding this comment.
this isn't a managed policy so we won't see the name in AWS, but I guess it asks the question if consistency even here would be helpful? Suffix vs prefix...
brettswift
reviewed
Oct 15, 2018
| @@ -155,7 +155,7 @@ def create_project(self, chain_context, codebuild_role, codebuild_environment, n | |||
| DependsOn=codebuild_role, | |||
| Artifacts=artifacts, | |||
| Environment=codebuild_environment, | |||
| Name=project_name, | |||
| Name="%s-%s" % (chain_context.instance_name, project_name), | |||
There was a problem hiding this comment.
This one is different too. It has a dash.
I'm sure there are a bunch of other inconsistencies.. so not asking for a change in this PR, but I'll create an issue on this board to address it.
brettswift
approved these changes
Oct 15, 2018
|
related issue: #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update naming of some Pipeline and CodeBuildAction resources to aid in making multiple instances of the same template generate unique resource names.