Expose the stacktrace created when connection is aquired during leak detection #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detection. This is useful for external leak detection logging
Codecov Report
@@ Coverage Diff @@
## dev #1272 +/- ##
============================================
- Coverage 74.53% 74.43% -0.11%
Complexity 557 557
============================================
Files 24 24
Lines 1940 1944 +4
Branches 265 265
============================================
+ Hits 1446 1447 +1
- Misses 349 352 +3
Partials 145 145
Continue to review full report at Codecov.
|
johnou
reviewed
Nov 14, 2018
| @@ -184,6 +184,17 @@ void cancelLeakTask() | |||
| leakTask.cancel(); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the stacktrace location of where the connection was acquired. If leak detection is not endabled, will | |||
|
how do the leak detection hooks work? could the existing logging be improved instead? |
brettwooldridge
force-pushed
the
dev
branch
2 times, most recently
from
6d319ab
to
7cacd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Again!
A small quality of life improvement to allow external users to get to the connection creation stacktrace. This is useful as I have leak detection hooks in my testing framework and when a leaked connection is detected being able to pull the stack trace right from the connection object is very convenient.
Open to any thoughts or getting this rejected, but figured I'd give it a shot.
If you are open to this, will add test case and address any feedback.