Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load hikari config properties file from classpath. #1384

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

puppylpg
Copy link

If one prefers load properties file from classpath, this(with a slash at the beginning) can be wired:

HikariConfig hikariConfig = new HikariConfig("/hikari.config.properties");

However, use ClassLoader.getResourceAsStream rather than Class.getResourceAsStream, the code makes sense:

HikariConfig hikariConfig = new HikariConfig("hikari.config.properties");

@puppylpg puppylpg force-pushed the load-properties-from-classpath branch from 869d3e9 to 644afdf Compare May 30, 2019 08:52
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@c509ec1). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1384   +/-   ##
======================================
  Coverage       ?   75.02%           
  Complexity     ?      547           
======================================
  Files          ?       24           
  Lines          ?     1934           
  Branches       ?      261           
======================================
  Hits           ?     1451           
  Misses         ?      339           
  Partials       ?      144           
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/zaxxer/hikari/HikariConfig.java 79.26% <0.00%> (ø) 120.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c509ec1...e3d5abf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant