Make BoundPool an es6 subclass of Pool
#2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes subtle subclassing bugs using es6 classes. It is a semver breaking change targeting 8.0 release...though it's not likely to cause issues in the general case.
|
#1541 was editable, so I brought it up to date with these tests and a smaller diff if you want ;) Then the other post-ES5 cleanup can go in on top of it so each change is more self-contained. |
|
alright i'll close this one & merge that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes subtle subclassing bugs using es6 classes. It is a semver breaking change targeting 8.0 release...though it's not likely to cause issues in the general case.
I'm merging this into the
bmc/8.0branch. This closes #1541 as it had merge conflicts since it got quite old & doesn't have tests...but I still appreciate the thought and work that went into it!