Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove early return for non commonjs environments #3033

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Remove early return for non commonjs environments #3033

merged 1 commit into from
Jul 19, 2023

Conversation

benjreinhart
Copy link
Contributor

Addresses #2980.

@nichochar
Copy link

Hey Brian 👋

Copy link
Owner

@brianc brianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice! sorry I missed this...thank you for doing this ❤️

@brianc brianc merged commit 3644730 into brianc:master Jul 19, 2023
15 checks passed
@benjreinhart benjreinhart deleted the remove-return branch July 19, 2023 00:05
@nichochar
Copy link

Thanks for merging @brianc .

Wondering if there's anything we can do to help release? We'd like to update some other libraries built on top of this and we have a bit of a waterfall of updates to deal with.

Appreciate your time!

thijs pushed a commit to thijs/node-postgres that referenced this pull request Aug 1, 2023
benjreinhart added a commit to axflow/axflow that referenced this pull request Aug 15, 2023
We previously supported pgvector but had to remove support due to a bug
that affected es6 environments like Nextjs. We since fixed that bug
upstream in (brianc/node-postgres#3033) and are
now re-introducing support for pgvector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants