Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application_name #497

Merged
merged 3 commits into from
Jan 6, 2014
Merged

application_name #497

merged 3 commits into from
Jan 6, 2014

Conversation

hoegaarden
Copy link
Contributor

Support for application_name and fallback_application_name

@hoegaarden hoegaarden closed this Jan 5, 2014
@hoegaarden
Copy link
Contributor Author

Must have accidentally hit the close button ...

@hoegaarden hoegaarden reopened this Jan 5, 2014
@hoegaarden
Copy link
Contributor Author

Hm ... I'm not sure why the tests fail with

[...]
max-connection-tests.js (native).......................
single-connection-tests.js (native)..
idle-timeout-tests.js (native).Message: Expected execution of function to be fired
AssertionError: Expected execution of function to be fired
    at null._onTimeout (/home/travis/build/brianc/node-postgres/test/test-helper.js:137:12)
    at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
 AssertionError: Expected execution of function to be fired
    at null._onTimeout (/home/travis/build/brianc/node-postgres/test/test-helper.js:137:12)
    at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
xargs: node: exited with status 255; aborting
make: *** [test-native] Error 124
[...]

I'm not really convinced that this failure has something to do with my changes ... 😉
But I'm on it ...

user: self.user,
database: self.database
});
con.startup(self.getStartupConf());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - i dig pulling this out into it's own method

@brianc
Copy link
Owner

brianc commented Jan 6, 2014

Awesome pull request! 💃 👍 I'll test & merge ASAP.

brianc added a commit that referenced this pull request Jan 6, 2014
@brianc brianc merged commit 22d5adb into brianc:master Jan 6, 2014
@brianc
Copy link
Owner

brianc commented Jan 6, 2014

Also - the reason the test was failing I think is it's somewhat time sensitive & travis-ci is often kinda slow...I'll try to adjust the timeout of the test to be a bit higher in travis.

@hoegaarden hoegaarden deleted the application_name branch January 6, 2014 14:22
@ismyrnow
Copy link

Just added documentation for these to the wiki.

Never knew these options were available, but it makes monitoring connections much easier.

@brianc
Copy link
Owner

brianc commented Oct 29, 2015

thanks for adding the documentation! I totally agree with you btw - makes figuring out who's connected much easier.

@abenhamdine
Copy link
Contributor

@ismyrnow Very useful ! Thx a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants