cpu: Expand dynamic detection to all supported OSs on AArch64.

briansmith · Sep 27, 2023 · 12ca250 · 12ca250
1 parent 7036949
commit 12ca250
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 14 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -167,7 +167,7 @@ name = "ring"
 getrandom = { version = "0.2.8" }
 untrusted = { version = "0.9" }
 
-[target.'cfg(any(target_arch = "x86",target_arch = "x86_64", all(any(target_arch = "aarch64", target_arch = "arm"), any(target_os = "android", target_os = "fuchsia", target_os = "linux", target_os = "windows"))))'.dependencies]
+[target.'cfg(any(target_arch = "x86",target_arch = "x86_64", all(target_arch = "aarch64", any(target_family = "unix", target_family = "windows")), all(target_arch = "arm", any(target_os = "android", target_os = "fuchsia", target_os = "linux", target_os = "windows"))))'.dependencies]
 spin = { version = "0.9.2", default-features = false, features = ["once"] }
 
 [target.'cfg(all(target_arch = "arm", any(target_os = "android", target_os = "linux")))'.dependencies]

diff --git a/src/cpu.rs b/src/cpu.rs
@@ -24,13 +24,30 @@ pub(crate) struct Features(());
 
 #[inline(always)]
 pub(crate) fn features() -> Features {
-    // We don't do runtime feature detection on aarch64-apple-* as all AAarch64
-    // features we use are available on every device since the first devices.
+    // TODO: The list of operating systems for `aarch64` should really be
+    // "whatever has `std::arch::is_aarch64_feature_detected`".
     #[cfg(any(
         target_arch = "x86",
         target_arch = "x86_64",
         all(
-            any(target_arch = "aarch64", target_arch = "arm"),
+            target_arch = "aarch64",
+            any(
+                target_os = "android",
+                target_os = "dragonfly",
+                target_os = "freebsd",
+                target_os = "illumos",
+                target_os = "ios",
+                target_os = "linux",
+                target_os = "macos",
+                target_os = "netbsd",
+                target_os = "openbsd",
+                target_os = "redox",
+                target_os = "solaris",
+                target_os = "windows",
+            )
+        ),
+        all(
+            target_arch = "arm",
             any(
                 target_os = "android",
                 target_os = "fuchsia",
@@ -52,15 +69,7 @@ pub(crate) fn features() -> Features {
                 }
             }
 
-            #[cfg(all(
-                any(target_arch = "aarch64", target_arch = "arm"),
-                any(
-                    target_os = "android",
-                    target_os = "fuchsia",
-                    target_os = "linux",
-                    target_os = "windows"
-                )
-            ))]
+            #[cfg(any(target_arch = "aarch64", target_arch = "arm"))]
             {
                 arm::setup();
             }

diff --git a/src/cpu/arm.rs b/src/cpu/arm.rs
@@ -67,7 +67,7 @@ macro_rules! features {
             };
         )+
 
-        #[cfg(target_arch = "aarch64")]
+        #[cfg(all(target_arch = "aarch64", any(target_family = "unix", target_family = "windows")))]
         pub fn setup() {
             extern crate std;
             use std::arch::is_aarch64_feature_detected;