Skip to content

Commit

Permalink
Enable i8 and u8 metrics test on Windows.
Browse files Browse the repository at this point in the history
These tests were disabled because they failed on Windows and it was
thought that MSVC's `alignas` was being "weird." It turns out that the
tests themselves were buggy. That bugginess was fixed in
5ffa243.
  • Loading branch information
briansmith committed Feb 7, 2016
1 parent b76f52c commit 72db3b2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/c.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,7 @@ define_type!(
should have explicit casts using `num::cast` or other methods that avoid
unintended truncation. Such code will then work on all platforms.");

// XXX: MSVC's `alignof` returns strange values for `int8_t`.
#[cfg(not(windows))]
define_metrics_tests!(i8, test_i8_metrics, ring_int8_t_align, ring_int8_t_size);

// XXX: MSVC's `alignof` returns strange values for `uint8_t`.
#[cfg(not(windows))]
define_metrics_tests!(u8, test_u8_metrics, ring_uint8_t_align,
ring_uint8_t_size);

Expand Down

0 comments on commit 72db3b2

Please sign in to comment.