Enable Windows on ARM builds for 0.16.x #1554
Conversation
|
@svenpaulsen @briansmith I switched to this branch for my own builds, and it works 👍 |
|
Hi @briansmith Do you think this could be merged soon? It currently blocks quite a few projects… |
| @@ -238,6 +269,12 @@ pub(crate) mod arm { | |||
|
|
|||
| #[cfg(all( | |||
| any(target_os = "android", target_os = "fuchsia", target_os = "linux"), | |||
There was a problem hiding this comment.
Shouldn't this line get deleted? The new block any block right under contains all the same oses, + windows.
error: failed to run custom build command for `ring v0.16.20` rust-lang/rustup#2612 briansmith/ring#1554 briansmith/ring#1551 briansmith/ring#1167
|
This is a very big change and I could use some hand-holding to understand it. I suspect that this PR is mostly copying things from the existing main branch. It would be extremely helpful if you could go through chunk-by-chunk in the GitHub review interface and explain where you copied the change from and why that change was copied, and go into more depth about how you came up with this set of changes in the first place. Especially regarding the PerlAsm changes, it would really help me if you could document why and from where you copied those changes. |
|
I left some comments in rust-lang/rustup#2612 (comment) that are very relevant to the development and review of this PR. |
|
Hey everyone, In case it is helpful, I just wanted to point out that we (1Password) backported the necessary components for WoA support in the 0.16 branch as part of 1Password/ring#8. The |
|
@briansmith Would it make it easier / less uncertain for you if someone (me?) created a pull request from the 1Password’s branch? I understand that you’re concerned about the extent of changes in this PR. |
|
@complexspaces Is it okay if I (or maybe you, if you’d prefer that) create a new PR from the branch you’ve mentioned? |
|
Alternatively, @svenpaulsen would you maybe kindly respond to @briansmith’s concerns here: #1554 (comment) 😊 I hope either should help. |
openssl/openssl@b863e1e which added Windows on ARM support to openssl |
|
Closing this as not planned. It has been years since we've done anything with 0.16.x. If any of these changes would be helpful for 0.17, PLMK. Thanks! |
Here's a PR to enable building 0.16.20 for Windows on ARM as requested in #1551.
Prerequisites to build from source: