Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and run tests for ARM. #171

Closed
wants to merge 4 commits into from
Closed

Conversation

pietro
Copy link
Contributor

@pietro pietro commented May 5, 2016

No description provided.

@pietro pietro mentioned this pull request May 5, 2016
5 tasks
@coveralls
Copy link

coveralls commented May 5, 2016

Coverage Status

Coverage remained the same at 63.831% when pulling 93990cd on pietro:arm_tests into c447603 on briansmith:master.

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage remained the same at 63.831% when pulling 2660cc0 on pietro:arm_tests into c447603 on briansmith:master.

@briansmith
Copy link
Owner

Thanks. I committed two of your commits in this PR as f59aa7d and 043dfef. I also added my own 63b10be to reduce some duplicated logic.

I didn't merge the travis_wait changes because, based on your comments, they don't solve the problem of the tests timing out. Let me know if I misunderstood.

Thanks a ton for doing this work!

@briansmith briansmith closed this May 9, 2016
@pietro
Copy link
Contributor Author

pietro commented May 11, 2016

They actually do, but the tests that around 30 minutes. So using 30 minutes sometimes worked and sometimes didn't. That's why I ended up setting the limit to 60 minutes which is higher than the total build time allowed by travis.

@pietro pietro deleted the arm_tests branch March 9, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants