Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec: Use LeakyLimb for public values. #2173

Merged
merged 1 commit into from
Dec 7, 2024
Merged

ec: Use LeakyLimb for public values. #2173

merged 1 commit into from
Dec 7, 2024

Conversation

briansmith
Copy link
Owner

@briansmith briansmith commented Dec 7, 2024

Take a step toward making Word (and Limb) opaque types.

This adds some unnecessary copies but the overhead is negligible as those copies are outside of loops.

@briansmith briansmith self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (5f3dbbf) to head (b4c63f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/arithmetic/constant.rs 0.00% 3 Missing ⚠️
src/ec/suite_b/ops/elem.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   96.91%   96.92%   +0.01%     
==========================================
  Files         154      154              
  Lines       20089    20124      +35     
  Branches      467      467              
==========================================
+ Hits        19470    19506      +36     
  Misses        512      512              
+ Partials      107      106       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Take a step toward making `Word` and `Limb` opaque types.

This adds some unnecessary copies but the overhead is
negligible as those copies are outside of loops.
@briansmith briansmith merged commit 6ce531b into main Dec 7, 2024
157 of 158 checks passed
@briansmith briansmith deleted the b/leakylimb branch December 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant