Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limbs/bigint: Make obvious LeakyLimb->Limb conversions explicit. #2174

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

briansmith
Copy link
Owner

@briansmith briansmith commented Dec 7, 2024

Take a step towards making Limb an opaque type.

Because of inference issues, places where we'd like to write Limb::from(<literal>) can't be written that way until Limb
(actually Word) becomes a newtype. There are only a few of these, so defer them until the actual newtype change happens.

@briansmith briansmith self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (6ce531b) to head (65972c1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2174      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files         154      154              
  Lines       20124    20150      +26     
  Branches      467      467              
==========================================
+ Hits        19505    19530      +25     
  Misses        512      512              
- Partials      107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Take a step towards making `Limb` an opaque type.

Because of inference issues, places where we'd like to write
`Limb::from(<literal>)` can't be written that way until `Limb`
(actually `Word`) becomes a newtype. There are only a few of these,
so defer them until the actual newtype change happens.
@briansmith briansmith merged commit 8086c79 into main Dec 8, 2024
158 checks passed
@briansmith briansmith deleted the b/leakylimb-2 branch December 8, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant