[WIP] Rsa keygen #731
[WIP] Rsa keygen #731
Conversation
|
@briansmith I've implemented some of the first steps of the primality testing algorithm. How does it look so far? As for the further steps, I don't know how to do the subtraction in Rust. There is subtraction support in the bignum module but it implements arithmetic modulo some number. This code however doesn't do that, it just uses vanilla bignums. There are functions |
| @@ -59,7 +57,64 @@ static uint16_t shift_and_add_mod_u16(uint16_t r, uint32_t a, uint16_t d, | |||
| return t; | |||
| } | |||
|
|
|||
| uint16_t bn_mod_u16_consttime(const BIGNUM *bn, uint16_t d) { | |||
|
|
|||
| // Function taken from boringssl's bn.c file. | |||
There was a problem hiding this comment.
Any code that comes from a file X in BoringSSL must be in a file named X in ring. Also, the license must be the same. The best way to add functions from bn.c would be to add one commit that is the latest unmodified version from BoringSSL, and then another commit that deletes everything except the license and the code you need.
Note that the licenses are different. That is actually why div.c and div_extra.c are separate files; the _extra files are ISC-licensed, the other files are "OpenSSL licensed," i.e. the bad license everybody is trying to get away from.
| @@ -150,3 +150,6 @@ mod private { | |||
| mod tests { | |||
| bssl_test!(test_constant_time, bssl_constant_time_test_main); | |||
| } | |||
|
|
|||
| // Only here for development | |||
| pub use rsa::key_generation::probable_primality_test; | |||
There was a problem hiding this comment.
It seems like you maybe forgot to git add this?
We cannot "port" code from BoringSSL unless it is ISC-licensed like div-extra. In particular, Unfortunately, because of the licensing issues, I need to close this PR. Please sort out the license-related stuff (email me if it is confusing: brian@briansmith.org) and submit a new PR. I appreciate your effort here but I need to make sure the licenses are respected and that the ring Rust code is under the ISC license. |
|
Hmmm will make a new attempt tomorrow then |
|
@briansmith okay I've removed the parts that I've taken from the C function |
Opened the PR so that I can discuss with @briansmith about the code. Nothing works yet. DON'T MERGE!
List of tasks:
BN_primality_testfunction)(p,q)prime pair(p,q)to create aring::signature::RSAKeyPairinstanceFixes #219