Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slice::iter #913

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Use slice::iter #913

merged 1 commit into from
Dec 23, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 30, 2019

See clippy::into_iter lint and rust-lang/rust#65819

@tesuji
Use array::iter
e43d98c 
See clippy::into_iter lint and rust-lang/rust#65819
@tesuji tesuji changed the title Use array::iter Use slice::iter Oct 30, 2019
@LukasKalbertodt
Copy link
Contributor

LukasKalbertodt commented Oct 30, 2019 •
edited
Loading

The CI error doesn't seem to have anything to do with this change. Instead, this Rust PR is likely relevant.

EDIT: fixed in #914

@tesuji tesuji closed this Oct 31, 2019
@tesuji tesuji reopened this Oct 31, 2019
@LukasKalbertodt LukasKalbertodt mentioned this pull request Nov 23, 2019
Merged
@briansmith briansmith merged commit c250e31 into briansmith:master Dec 23, 2019
@briansmith
Copy link
Owner

Thanks!

@tesuji tesuji deleted the patch-1 branch December 23, 2019 18:43
@LukasKalbertodt
Copy link
Contributor

@briansmith Thanks for merging! Do you think you could release this as 0.16.10?

@briansmith
Copy link
Owner

@briansmith Thanks for merging! Do you think you could release this as 0.16.10?

I plan to do a release in early January.

@LukasKalbertodt
Copy link
Contributor

@briansmith I hope I'm not too annoying, but do you think you could release this soonish? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briansmith briansmith briansmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesuji @LukasKalbertodt @briansmith