Support for Rake, Rack and Roda (and Puma) #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-api-pr-281.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1nndlvcq1lusigqtkr0. |
|
Your Render PR Server URL is https://bridgetown-main-pr-281.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1nndm7cq1lusigqtkv0. |
|
|
|
Yay, deploying now on both Netlify and Render. 👍 |
* Relations for resources (belongs_to, has_many, etc) * improve resource type comments * Make relations available to Liquid templates * remove stray p methods * Add test for resource relationships * Support pluralized belongs_to keys * make cop happy * Use model origin id for resource id * Add documentation and Liquid test for resource relations * use newer feed gem * Use list for relation accessor examples * Fix nil bug in relations schema
* New Component class with a ViewComponent-ish API * Isolate site in components and improve link helpers * Remove unnecessary special render case for ViewComponent * Fix missing variables * Relocate markdownify to Helpers class * Switch to new Rails-like OutputBuffer, more VC support * Support clean render interop between builtin Component and VCs * Add several common Liquid filters in as Ruby helpers Also add output_safety dependency * Additional html_safe usage * Match Rails' capture escaping logic * Change before_render behavior to match latest VC * Add tests and code comments for Bridgetown::Component * Couple of YARD updates * fix cop offense * Fix bug with url_for helper * Correct failing ERB feature test * Use new SEO and feed helpers for the website * Fix odd cop errors * Convert website navbar to ERB component * fix is-active class name * Use resource variable in default website layout * Update documentation (WIP) on components subsystem Also change all occurences of Javascript to JavaScript * Add lint-html addition * Add documentation regarding ViewComponent * Make linthtml happy * Fix typos * Add link to components docs from the ERB page * Add section on ERB output safety to the docs
* Major feature addition for Ruby Front Matter and raw templates Also additional work to normalize Liquid & ERB template APIs * Improve docs * improve error messages, support Ruby data files * Add to_json support for Resources * Improve code quality and test rbfm * Refactor front matter importing and add rbfm to layouts * Revert and use regex capture * Remove logging around rbfm * Lots of Ruby files and rbfm documentation, couple of fixes * Better to_json compat * Fix Liquid error on website build
* Fix bug which was swallowing dotfiles and multiple extensions * Revert tag refactoring
|
Should check our out-of-the-box Puma config: |
|
Your Render PR Server URL is https://bridgetown-beta-pr-281.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2bnojc64cktggq9vq9g. |
|
Closing in favor of the newer #383. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
June update: this is now top priority for me, next to getting all docs/features wrapped up for the official Resource engine switch.
I'll need to circle back to fully document this, because holy moly this was complicated. But in the end, worth it.
outputfolder, but it can easily be augmented to handle all kinds of dynamic server abilities including mounting a Rails (or any other Rack-based) appbundle execnastiness and use a binstub — I also want to document doingalias bt="bin/bridgetown"because then it's a cinchyarnto bootstrap everything.bt start>yarn start. Moar Ruby =)Probably will want to put together an automation to upgrade old Bridgetown sites (otherwise it's a bunch of manual editing of files like
package.jsonand adding in new stuff). Should look into how it could intersect with #250Resolves #280, #269
Closes #37