Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added analytics request method to Client class #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added analytics request method to Client class #21

wants to merge 1 commit into from

Conversation

dividemysky
Copy link

Added a method to the Client class to allow requests to the Analytics API. An additional method is necessary because the URL formatting and options are different for the Analytics endpoint.

tamasd
tamasd suggested changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@tamasd tamasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functioanlity should have its own class, like CMS, DI or PM, and not be a part of the Client class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasd tamasd tamasd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dividemysky @tamasd