update: use staticString extension of URL, fix more lint-issues

Tests/ContributeWordPressTests/FileManagerExtensionTests.swift

@@ -15,7 +15,7 @@ internal final class FileManagerExtensionTests: XCTestCase {
     XCTAssertThrowsError(
       try FileManager.createDirectory(
         withName: "test",
-        in: try .make(string: "/fake/path")
+        in: URL("/fake/path")
       )
     )
   }

Tests/ContributeWordPressTests/Helpers/Extension/FakeData/AssetImport+Fake.swift

@@ -5,7 +5,7 @@ extension AssetImport {
   internal static func makeAssetImportForAttachmentA() throws -> AssetImport {
     try .make(
       forPost: .attachmentA(),
-      sourceURL: try .make(string: "http://leogdion.name")
+      sourceURL: URL("http://leogdion.name")
     )
   }
 }

Tests/ContributeWordPressTests/Helpers/Extension/FakeData/WordPressPost+Fake.swift

@@ -10,7 +10,7 @@ extension WordPressPost {
       postID: 1,
       title: "2018 - My Year in Review",
       contentEncoded: .myYearInReviewContent,
-      link: try .make(string: "https://leogdion.name/2019/01/14/2018-review/"),
+      link: URL("https://leogdion.name/2019/01/14/2018-review/"),
       description: "My main goal this year was to produce more content online and less time on local events and gatherings. Unfortunately, that wasn't the case.",
       postName: "2018-review",
       categories: tags ?? []
@@ -22,7 +22,7 @@ extension WordPressPost {
       postID: 2,
       title: "Are We There Yet?",
       contentEncoded: .areWeThereYetContent,
-      link: .make(string: "https://leogdion.name/2018/12/13/are-we-there-yet/"),
+      link: URL("https://leogdion.name/2018/12/13/are-we-there-yet/"),
       postName: "are-we-there-yet",
       categories: tags ?? []
     )
@@ -33,7 +33,7 @@ extension WordPressPost {
       postID: 3,
       title: "From Goals to Actions 2018",
       contentEncoded: .fromGoalsToActionsContent,
-      link: .make(string: "https://leogdion.name/2018/01/08/from-goals-to-actions-2018/diagram-for-goals/"),
+      link: URL("https://leogdion.name/2018/01/08/from-goals-to-actions-2018/diagram-for-goals/"),
       postName: "from-goals-to-actions-2018",
       categories: tags ?? []
     )
@@ -44,7 +44,7 @@ extension WordPressPost {
       postID: 4,
       title: "Podcasting - Getting Started - Whys and Hows",
       contentEncoded: .podcastingContent,
-      link: .make(string: "https://leogdion.name/2019/06/13/podcasting-getting-started-content-recording-audience/"),
+      link: URL("https://leogdion.name/2019/06/13/podcasting-getting-started-content-recording-audience/"),
       description: "Generally speaking, podcasting gives specific audiences an in-depth specialized analysis without the need to appeal to the general audience.",
       postName: "podcasting-getting-started-content-recording-audience",
       categories: tags ?? []
@@ -58,7 +58,7 @@ extension WordPressPost {
       postID: 4,
       title: "Productivity Apps for Developers (and Everyone Else)",
       contentEncoded: .productivityContent,
-      link: .make(string: "https://leogdion.name/2019/08/01/productivity-apps-for-developers-and-everyone/"),
+      link: URL("https://leogdion.name/2019/08/01/productivity-apps-for-developers-and-everyone/"),
       description: "It's important to keep a set of great productivity app which help me optimize rather than distract. Here's a list of productivity apps and services to help you.",
       postName: "productivity-apps-for-developers-and-everyone",
       categories: tags ?? []

Tests/ContributeWordPressTests/Helpers/Extension/FakeData/WordPressSite+Fake.swift

@@ -6,14 +6,14 @@ extension WordPressSite {
   internal static func leogdion() throws -> WordPressSite {
     try .make(
       title: "Leo G Dion",
-      link: try .make(string: "https://leogdion.name"),
+      link: URL("https://leogdion.name"),
       description: "Personal Blog",
       categories: [
         .init(termID: 1, niceName: "uncategorized", parent: "", name: "Uncategorized")
       ],
       tags: leogdionTags(),
-      baseSiteURL: URL(string: "https://leogdion.name"),
-      baseBlogURL: URL(string: "https://leogdion.name"),
+      baseSiteURL: URL("https://leogdion.name"),
+      baseBlogURL: URL("https://leogdion.name"),
       posts: try leogdionPosts()
     )
   }

Tests/ContributeWordPressTests/Helpers/Extension/URL.swift

@@ -0,0 +1,16 @@
+import Foundation
+
+extension URL {
+  internal init(_ staticString: StaticString) {
+    guard let url = URL(string: .init(describing: staticString)) else {
+      fatalError("Invalid URL String")
+    }
+    self = url
+  }
+}
+
+extension URL {
+  internal static func makeRootPublishSiteURL() -> URL {
+    .temporaryDirURL.appendingPathComponent(UUID().uuidString)
+  }
+}

Tests/ContributeWordPressTests/Images/AssetDownloaderTests.swift

@@ -53,8 +53,8 @@ internal final class AssetDownloaderTests: XCTestCase {
         forPost: try .myYearInReviewPost(),
         sourceURL: .temporaryResourcesPathURL,
         assetRoot: "/media/wp-assets",
-        resourcesPathURL: try .make(
-          string: "https://leogdion.name/wp-content/uploads/2019/06/-unsplash-701.jpeg"
+        resourcesPathURL: URL(
+          "https://leogdion.name/wp-content/uploads/2019/06/-unsplash-701.jpeg"
         ),
         importPathURL: nil
       )

Tests/ContributeWordPressTests/Images/AssetImportWordPressTests.swift

@@ -4,7 +4,7 @@ import XCTest
 internal final class AssetImportWordPressTests: XCTestCase {
   internal func testExtractAssetImportFromPostWithAssets() throws {
     let site: WordPressSite = try .make(
-      link: try .make(string: "https://leogdion.name"),
+      link: URL("https://leogdion.name"),
       posts: [.myYearInReviewPost()]
     )
 
@@ -25,7 +25,7 @@ internal final class AssetImportWordPressTests: XCTestCase {
 
   internal func testExtractAssetImportFromPostWithoutAssets() throws {
     let site: WordPressSite = try .make(
-      link: try .make(string: "https://leogdion.name"),
+      link: URL("https://leogdion.name"),
       posts: [.make(postID: 00, title: "fake", contentEncoded: "")]
     )
 

Tests/ContributeWordPressTests/URLExtensionTests.swift

@@ -6,7 +6,7 @@ internal final class URLExtensionTests: XCTestCase {
     let expectedString = "banner.jpg"
     let filename = expectedString + ".jpg"
 
-    let url: URL = try .make(string: "https://leogdion.name/wp-content/uploads/2018/12/")
+    let url = URL("https://leogdion.name/wp-content/uploads/2018/12/")
       .appendingPathComponent(filename)
 
     let actualString = url.lastPathComponentWithoutExtension()
@@ -30,7 +30,7 @@ internal final class URLExtensionTests: XCTestCase {
   }
 
   internal func testRelativePathFromBaseNotFileURLShouldBeNil() throws {
-    let projectPathURL: URL = try .make(string: "http://www.google.com")
+    let projectPathURL = URL("http://www.google.com")
 
     let expectedRelativePath = PublishDefaults.resourcesDirectoryName