working on linting

.swiftformat

@@ -2,6 +2,6 @@
 --header strip
 --commas inline
 --disable wrapMultilineStatementBraces
---extensionacl on-extension
+--extensionacl on-declarations
 --decimalgrouping 3,4
 --exclude .build, DerivedData

Package.swift

@@ -1,5 +1,5 @@
 // swift-tools-version:5.5
-// swiftlint:disable explicit_top_level_acl
+// swiftlint:disable explicit_top_level_acl explicit_acl
 import PackageDescription
 
 let package = Package(

Sources/SyndiKit/Character.swift

@@ -1,7 +1,7 @@
 import Foundation
 
 extension Character {
-  func asOsmType() -> PodcastLocation.OsmQuery.OsmType? {
+  internal func asOsmType() -> PodcastLocation.OsmQuery.OsmType? {
     .init(rawValue: String(self))
   }
 }

Sources/SyndiKit/Collection.swift

@@ -1,7 +1,7 @@
 import Foundation
 
 extension Collection {
-  subscript(safe index: Index) -> Element? {
+  internal subscript(safe index: Index) -> Element? {
     indices.contains(index) ? self[index] : nil
   }
 }

Sources/SyndiKit/Common/Author.swift

@@ -2,12 +2,6 @@ import Foundation
 
 /// a person, corporation, or similar entity.
 public struct Author: Codable, Equatable {
-  init(name: String) {
-    self.name = name
-    email = nil
-    uri = nil
-  }
-
   /// Conveys a human-readable name for the person.
   public let name: String
 
@@ -16,4 +10,10 @@ public struct Author: Codable, Equatable {
 
   /// Contains a home page for the person.
   public let uri: URL?
+
+  internal init(name: String) {
+    self.name = name
+    email = nil
+    uri = nil
+  }
 }

Sources/SyndiKit/Common/Primitives/CData.swift

@@ -1,9 +1,8 @@
 /// #CDATA XML element.
+public typealias StringLiteralType = String
 public struct CData: Codable, ExpressibleByStringLiteral, Equatable {
-  public typealias StringLiteralType = String
-
-  public init(stringLiteral value: String) {
-    self.value = value
+  public enum CodingKeys: String, CodingKey {
+    case value = "#CDATA"
   }
 
   public var description: String {
@@ -13,8 +12,8 @@ public struct CData: Codable, ExpressibleByStringLiteral, Equatable {
   /// String value of the #CDATA element.
   public let value: String
 
-  enum CodingKeys: String, CodingKey {
-    case value = "#CDATA"
+  public init(stringLiteral value: String) {
+    self.value = value
   }
 
   public init(from decoder: Decoder) throws {

Sources/SyndiKit/Common/Primitives/XMLStringInt.swift

@@ -1,14 +1,14 @@
 /// XML Element which contains a `String` parsable into a `Integer`.
 public struct XMLStringInt: Codable, ExpressibleByIntegerLiteral {
-  public init(integerLiteral value: Int) {
-    self.value = value
-  }
-
   public typealias IntegerLiteralType = Int
 
   /// The underlying `Int` value.
   public let value: Int
 
+  public init(integerLiteral value: Int) {
+    self.value = value
+  }
+
   public init(from decoder: Decoder) throws {
     let container = try decoder.singleValueContainer()
     let stringValue = try container.decode(String.self)

Sources/SyndiKit/Decoding/AnyDecoding.swift

@@ -1,6 +1,6 @@
 import Foundation
 
-protocol AnyDecoding {
+internal protocol AnyDecoding {
   static var label: String { get }
   func decodeFeed(data: Data) throws -> Feedable
 }

Sources/SyndiKit/Decoding/CustomDecoderSetup.swift

@@ -1,5 +1,5 @@
 import Foundation
 
-protocol CustomDecoderSetup {
+internal protocol CustomDecoderSetup {
   func setup(decoder: TypeDecoder)
 }

Sources/SyndiKit/Decoding/DateFormatterDecoder.swift

@@ -1,26 +1,26 @@
 import Foundation
 
-struct DateFormatterDecoder {
-  let formatters: [DateFormatter]
-
-  public enum RSS {
-    static let dateFormatStrings = [
+internal struct DateFormatterDecoder {
+  internal enum RSS {
+    private static let dateFormatStrings = [
       "yyyy-MM-dd'T'HH:mm:ss.SSSXXXXX",
       "yyyy-MM-dd'T'HH:mm:ssXXXXX",
       "E, d MMM yyyy HH:mm:ss zzz",
       "yyyy-MM-dd HH:mm:ss"
     ]
 
-    public static let decoder = DateFormatterDecoder(
+    internal static let decoder = DateFormatterDecoder(
       basedOnFormats: Self.dateFormatStrings
     )
   }
 
+  private let formatters: [DateFormatter]
+
   internal init(formatters: [DateFormatter]) {
     self.formatters = formatters
   }
 
-  static func isoPOSIX(withFormat dateFormat: String) -> DateFormatter {
+  private static func isoPOSIX(withFormat dateFormat: String) -> DateFormatter {
     let formatter = DateFormatter()
     formatter.calendar = Calendar(identifier: .iso8601)
     formatter.locale = Locale(identifier: "en_US_POSIX")
@@ -29,11 +29,11 @@ struct DateFormatterDecoder {
     return formatter
   }
 
-  init(basedOnFormats formats: [String]) {
+  internal init(basedOnFormats formats: [String]) {
     formatters = formats.map(Self.isoPOSIX(withFormat:))
   }
 
-  public func decodeString(_ dateStr: String) -> Date? {
+  internal func decodeString(_ dateStr: String) -> Date? {
     for formatter in formatters {
       if let date = formatter.date(from: dateStr) {
         return date
@@ -42,7 +42,7 @@ struct DateFormatterDecoder {
     return nil
   }
 
-  func decode(from decoder: Decoder) throws -> Date {
+  internal func decode(from decoder: Decoder) throws -> Date {
     let container = try decoder.singleValueContainer()
     let dateStr = try container.decode(String.self)
 

Sources/SyndiKit/Decoding/DecodableFeed.swift

@@ -1,16 +1,16 @@
 import Foundation
 
-protocol DecodableFeed: Decodable, Feedable {
+internal protocol DecodableFeed: Decodable, Feedable {
   static var source: DecoderSetup { get }
   static var label: String { get }
 }
 
 extension DecodableFeed {
-  static func decoding(using decoder: TypeDecoder) -> Decoding<Self> {
+  internal static func decoding(using decoder: TypeDecoder) -> Decoding<Self> {
     Decoding(for: Self.self, using: decoder)
   }
 
-  static func anyDecoding(using decoder: TypeDecoder) -> AnyDecoding {
+  internal static func anyDecoding(using decoder: TypeDecoder) -> AnyDecoding {
     Self.decoding(using: decoder)
   }
 }

Sources/SyndiKit/Decoding/DecoderSetup.swift

@@ -1,5 +1,5 @@
 import Foundation
 
-protocol DecoderSetup {
+internal protocol DecoderSetup {
   var source: DecoderSource { get }
 }

Sources/SyndiKit/Decoding/DecoderSource.swift

@@ -1,10 +1,10 @@
 import Foundation
 
-enum DecoderSource: UInt8, DecoderSetup {
+internal enum DecoderSource: UInt8, DecoderSetup {
   case json = 0x007B
   case xml = 0x003C
 
-  public var source: DecoderSource {
+  internal var source: DecoderSource {
     self
   }
 }

Sources/SyndiKit/Decoding/Decoding.swift

@@ -1,21 +1,21 @@
 import Foundation
 
-struct Decoding<DecodingType: DecodableFeed>: AnyDecoding {
-  func decodeFeed(data: Data) throws -> Feedable {
-    try decode(data: data)
+internal struct Decoding<DecodingType: DecodableFeed>: AnyDecoding {
+  internal static var label: String {
+    DecodingType.label
   }
 
-  let decoder: TypeDecoder
+  internal let decoder: TypeDecoder
 
-  init(for _: DecodingType.Type, using decoder: TypeDecoder) {
+  internal init(for _: DecodingType.Type, using decoder: TypeDecoder) {
     self.decoder = decoder
   }
 
-  func decode(data: Data) throws -> DecodingType {
-    try decoder.decode(DecodingType.self, from: data)
+  internal func decodeFeed(data: Data) throws -> Feedable {
+    try decode(data: data)
   }
 
-  static var label: String {
-    DecodingType.label
+  internal func decode(data: Data) throws -> DecodingType {
+    try decoder.decode(DecodingType.self, from: data)
   }
 }

Sources/SyndiKit/Decoding/DecodingError.swift

@@ -1,18 +1,18 @@
 import Foundation
 
 extension DecodingError {
-  struct Dictionary: Error {
+  private struct Dictionary: Error {
     internal init?(errors: [String: DecodingError]) {
       guard errors.count > 1 else {
         return nil
       }
       self.errors = errors
     }
 
-    let errors: [String: DecodingError]
+    private let errors: [String: DecodingError]
   }
 
-  static func failedAttempts(_ errors: [String: DecodingError]) -> Self {
+  internal static func failedAttempts(_ errors: [String: DecodingError]) -> Self {
     let context = DecodingError.Context(
       codingPath: [],
       debugDescription: "Failed to decode data with several decoders.",

Sources/SyndiKit/Decoding/SynDecoder.swift

@@ -12,18 +12,18 @@ import XMLCoder
 ///
 /// - ``decode(_:)``
 public class SynDecoder {
-  static func setupJSONDecoder(_ decoder: JSONDecoder) {
+  internal static func setupJSONDecoder(_ decoder: JSONDecoder) {
     decoder.keyDecodingStrategy = .convertFromSnakeCase
     decoder.dateDecodingStrategy = .custom(DateFormatterDecoder.RSS.decoder.decode(from:))
   }
 
-  static func setupXMLDecoder(_ decoder: XMLDecoder) {
+  internal static func setupXMLDecoder(_ decoder: XMLDecoder) {
     decoder.keyDecodingStrategy = .convertFromSnakeCase
     decoder.dateDecodingStrategy = .custom(DateFormatterDecoder.RSS.decoder.decode(from:))
     decoder.trimValueWhitespaces = false
   }
 
-  init(
+  internal init(
     types: [DecodableFeed.Type]? = nil,
     defaultJSONDecoderSetup: ((JSONDecoder) -> Void)? = nil,
     defaultXMLDecoderSetup: ((XMLDecoder) -> Void)? = nil
@@ -38,29 +38,29 @@ public class SynDecoder {
     self.init(types: nil, defaultJSONDecoderSetup: nil, defaultXMLDecoderSetup: nil)
   }
 
-  let defaultJSONDecoderSetup: (JSONDecoder) -> Void
-  let defaultXMLDecoderSetup: (XMLDecoder) -> Void
-  let types: [DecodableFeed.Type]
+  private let defaultJSONDecoderSetup: (JSONDecoder) -> Void
+  private let defaultXMLDecoderSetup: (XMLDecoder) -> Void
+  private let types: [DecodableFeed.Type]
 
-  static let defaultTypes: [DecodableFeed.Type] = [
+  private static let defaultTypes: [DecodableFeed.Type] = [
     RSSFeed.self,
     AtomFeed.self,
     JSONFeed.self
   ]
 
-  lazy var defaultXMLDecoder: XMLDecoder = {
+  private lazy var defaultXMLDecoder: XMLDecoder = {
     let decoder = XMLDecoder()
     self.defaultXMLDecoderSetup(decoder)
     return decoder
   }()
 
-  lazy var defaultJSONDecoder: JSONDecoder = {
+  private lazy var defaultJSONDecoder: JSONDecoder = {
     let decoder = JSONDecoder()
     self.defaultJSONDecoderSetup(decoder)
     return decoder
   }()
 
-  lazy var decodings: [DecoderSource: [String: AnyDecoding]] = {
+  private lazy var decodings: [DecoderSource: [String: AnyDecoding]] = {
     let decodings = types.map { type -> (DecoderSource, AnyDecoding) in
       let source = type.source
       let setup = type.source as? CustomDecoderSetup

Sources/SyndiKit/Decoding/TypeDecoder.swift

@@ -1,7 +1,7 @@
 import Foundation
 import XMLCoder
 
-protocol TypeDecoder {
+internal protocol TypeDecoder {
   func decode<T>(_ type: T.Type, from data: Data) throws -> T where T: DecodableFeed
 }
 

Sources/SyndiKit/Dictionary.swift

@@ -1,5 +1,5 @@
 extension Dictionary {
-  mutating func formUnion<SequenceType: Sequence, ElementType>(
+  internal mutating func formUnion<SequenceType: Sequence, ElementType>(
     _ collection: SequenceType,
     key: Key
   ) where Value == Set<ElementType>, SequenceType.Element == ElementType {

Sources/SyndiKit/Formats/Blogs/SiteDirectory.swift

@@ -17,8 +17,8 @@ public protocol SiteDirectory {
   var categories: CategorySequence { get }
 }
 
-public extension SiteDirectory {
-  func sites(
+extension SiteDirectory {
+  public func sites(
     withLanguage language: SiteLanguageType? = nil,
     withCategory category: SiteCategoryType? = nil
   ) -> SiteSequence {
@@ -35,7 +35,7 @@ public struct SiteCollectionDirectory: SiteDirectory {
   public typealias CategorySequence =
     Dictionary<SiteCategoryType, SiteCategory>.Values
 
-  let instance: Instance
+  private let instance: Instance
 
   public var languages: Dictionary<
     SiteLanguageType, SiteLanguage
@@ -56,16 +56,16 @@ public struct SiteCollectionDirectory: SiteDirectory {
     instance.sites(withLanguage: language, withCategory: category)
   }
 
-  init(blogs: SiteCollection) {
+  internal init(blogs: SiteCollection) {
     instance = .init(blogs: blogs)
   }
 
-  struct Instance {
-    let allSites: [Site]
-    let languageDictionary: [SiteLanguageType: SiteLanguage]
-    let categoryDictionary: [SiteCategoryType: SiteCategory]
-    let languageIndicies: [SiteLanguageType: Set<Int>]
-    let categoryIndicies: [SiteCategoryType: Set<Int>]
+  private struct Instance {
+    internal let allSites: [Site]
+    internal let languageDictionary: [SiteLanguageType: SiteLanguage]
+    internal let categoryDictionary: [SiteCategoryType: SiteCategory]
+    internal let languageIndicies: [SiteLanguageType: Set<Int>]
+    internal let categoryIndicies: [SiteCategoryType: Set<Int>]
 
     public func sites(
       withLanguage language: SiteLanguageType?,
@@ -107,7 +107,7 @@ public struct SiteCollectionDirectory: SiteDirectory {
     }
 
     // swiftlint:disable function_body_length
-    init(blogs: SiteCollection) {
+    internal init(blogs: SiteCollection) {
       var categories = [CategoryLanguage]()
       var languages = [SiteLanguage]()
       var sites = [Site]()