Fix strict lint voilations #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.4.0-STRICT #67 +/- ##
================================================
Coverage ? 81.43%
================================================
Files ? 50
Lines ? 1056
Branches ? 0
================================================
Hits ? 860
Misses ? 196
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@leogdion The fixes here are just the simple fixes, for more fixes like body length, missing docs, I am working on different branch so we don't mess with this one. |
leogdion
requested changes
Jan 22, 2024
leogdion
added a commit
that referenced
this pull request
Jan 26, 2024
* Support Option Link for RSS (#65) * updating workflow * adding more workflows * fixup! adding more workflows * Update dependabot.yml * working on linting * [skip ci] fixing linting * fix: errors with tests * fix: possible lint issues * fix: SiteCollectionDirectory.Instance to be internal than private * mint-upgrade: periphery from 2.12.3 to 2.18.0 * resolve PR conversations * redo: post.id back to post.ID * fix: post.ID and make the property called ID * Fix strict lint voilations (#67) * fixup! fix: post.ID and make the property called ID * Any other lint violations that are not 'Missing Docs Violation' (#68) * lint-fixes: any voilation that is not 'Missing Docs Violation' * fixup! Merge branch 'v0.4.0-STRICT-changes' into v0.4.0-STRICT-others --------- Co-authored-by: leogdion <leogdion@brightdigit.com> * Adding Documentation Comments --------- Co-authored-by: Ahmed Shendy <dev.ahmed.shendy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.