Added memoization in expiry time in some places #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added memoization in status dropdown and profile popover Added logic to show tooltip in custom status emoji in channel header Refactored some code in custom status emoji and custom status selector Added timezone dependent current time in custom status selector
Sorted the order of imports in several files Made unit tests for date_time_input and expiry_menu components Updated some snapshots
…app into MI-1235 * 'MI-1235' of github.com:brightscout-alpha/mattermost-webapp: Fixed custom status emoji unit tests
chetanyakan
reviewed
May 4, 2021
Converted displayExpiryTime util to a separate functional component Replaced use of util with component everywhere Fixed styling of date time input Refactored disabling set status button in custom status modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added memoization in status dropdown and profile popover
Added logic to show tooltip in custom status emoji in channel header
Refactored some code in custom status emoji and custom status selector
Added timezone dependent current time in custom status selector
Summary
Ticket Link
Related Pull Requests
Screenshots
Release Note