Reparametrize lognormals for ecospold2 imports #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the definition of the ecospold2 format, the mean of a lognormal distribution of an exchange is not equal to the amount specified for that exchange, see issue brightway-lca/brightway2-calc#76.
This PR adds a strategy which sets
loc
for lognormal distributions on imported databases such that the expected value (mean) of the resulting distribution is equal to the (static) amount specified for that exchange. More precisely,where$a$ is the (static) amount and $\sigma$ is
scale
, i.e., the standard deviation of the underlying normal distribution.The strategy is not applied by default but only if a specific flag (
reparametrize_lognormals=True
) is provided when initializing an instance ofSingleOutputEcospold2Importer
.