Add MacPorts support with preconditions #33
Conversation
Resolve brikis98#32 Alternatives to HomeBrew by MacPorts with preconditions: - Boot2Docker - Docker Compose
|
Thank you for the pull request. I like the general approach and I think this could be made to work, but as I mentioned in #32, before increasing the complexity of the installer, we need to find a way to add good automated tests, which is currently blocked by #7. On a side note, this PR seems to have a lot of whitespace changes, which makes it hard to identify the real changes. Could you check your text editor settings for what could be causing that? |
| # Checks if all MacPorts requirements are met. | ||
| # | ||
| function check_port_prerequisites { | ||
| if ! type boot2docker > /dev/null 2>&1 ; then |
There was a problem hiding this comment.
Boot2Docker is one of the items in the port_install list. Why is it a prerequisite?
There was a problem hiding this comment.
One of the reasons why a single install method is a bad idea and would grow
into conditional spaghetti: MacPorts has no Portfile for Boot2Docker or
Docker Compose.
Package was incorrectly reported to be installed. grepped port list command avoids such behaviour.
|
Dumping maintenance on this PR. Diverged. |
Resolve #32 Alternatives to HomeBrew by MacPorts with preconditions: