Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade TypeScript, fix 5.6 error #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Upgrade TypeScript, fix 5.6 error #272

wants to merge 1 commit into from

Conversation

tmcw
Copy link

@tmcw tmcw commented Sep 16, 2024

The behavior of

return !utils.access(data, check);

and

return !utils.access(data, check) ?? true;

Is identical because false ?? true === false and true ?? true === true.

@tmcw
Copy link
Author

tmcw commented Oct 25, 2024

Any chance this'll get merged? This is going to prevent people from using arborist with TypeScript 5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with TypeScript 5.6
1 participant
@tmcw