Add missing timeout property to type. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatveev
approved these changes
May 8, 2024
yosiat
approved these changes
May 8, 2024
| @@ -10,6 +10,8 @@ declare class ProducerError extends Error { | |||
| interface ProduceOptions extends amqp.Options.Publish { | |||
| routingKey?: string; | |||
| rpc?: boolean; | |||
| /** Timeout in milliseconds for producing RPC request and waiting for the response. Does not affect non-rpc requests. */ | |||
There was a problem hiding this comment.
Suggested change
| /** Timeout in milliseconds for producing RPC request and waiting for the response. Does not affect non-rpc requests. */ | |
| // Timeout in milliseconds for producing RPC request and waiting for the response. Does not affect non-rpc requests. |
There was a problem hiding this comment.
Why comment needed, specifically for this field?
I suggest either document all properties, or none. Lets be consistent.
There was a problem hiding this comment.
The options are not intuitive, so I added docs to all of them.
shamil
requested changes
May 8, 2024
| @@ -10,6 +10,8 @@ declare class ProducerError extends Error { | |||
| interface ProduceOptions extends amqp.Options.Publish { | |||
| routingKey?: string; | |||
| rpc?: boolean; | |||
| /** Timeout in milliseconds for producing RPC request and waiting for the response. Does not affect non-rpc requests. */ | |||
There was a problem hiding this comment.
Why comment needed, specifically for this field?
I suggest either document all properties, or none. Lets be consistent.
ramhr
force-pushed
the
add_timeout_property_to_type
branch
from
2662e2a
to
81b7bbf
Compare
shamil
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.