Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update README.md for CMS 5 #195

Merged
merged 1 commit into from
Apr 20, 2023
Merged

DOC Update README.md for CMS 5 #195

merged 1 commit into from
Apr 20, 2023

Conversation

GuySartorelli
Copy link
Collaborator

@GuySartorelli GuySartorelli mentioned this pull request Apr 19, 2023
Closed
5 tasks
@GuySartorelli GuySartorelli marked this pull request as draft April 19, 2023 04:15
@GuySartorelli GuySartorelli force-pushed the pulls/3.0/cms5-readme branch from 4bb628c to 35bd009 Compare April 19, 2023 05:32
@GuySartorelli GuySartorelli marked this pull request as ready for review April 19, 2023 05:32
sabina-talipova
sabina-talipova reviewed Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@sabina-talipova sabina-talipova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you think, should we update a section How your composer.json influences the report in this file?

@GuySartorelli
Copy link
Collaborator Author

Do you mean specifically to change the examples from CMS 4 examplkes to CMS 5 examples? I don't think that's necessary. The examples hold true without being changed.

sabina-talipova
sabina-talipova approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@sabina-talipova sabina-talipova merged commit 80762b2 into bringyourownideas:3.0 Apr 20, 2023
@sabina-talipova sabina-talipova deleted the pulls/3.0/cms5-readme branch April 20, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabina-talipova sabina-talipova sabina-talipova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @sabina-talipova