Add woa23 #21
Add woa23 #21
Conversation
| @@ -55,9 +55,9 @@ function mean_std_and_number_obs(ds, tracer) | |||
| lon = mod.(ds["lon"][:] .|> Float64, 360) | |||
| lat = ds["lat"][:] .|> Float64 | |||
| depth = ds["depth"][:] .|> Float64 | |||
| μ3D = ds[WOA_varname(tracer, "mn")][:][:, :, :, 1] | |||
There was a problem hiding this comment.
Would you mind explaining this change? If I remember correctly this X[:][:,:,:,1] syntax was required for the array to be materialized (and not just a lazy representation) and this made the processing that followed faster. Maybe I'm remembering incorrectly or things have changed upstream since then?
There was a problem hiding this comment.
I believe this is needed with NCDatasets.jl 0.14 (compat was limited to 0.12 in Project.toml) where X[:] results in a 1D vector. Maybe the compat entry should be NCDatasets = "0.14" with this change. Not sure but seems better than sticking with 0.12.
There was a problem hiding this comment.
Yes that's better I'll do that
|
Thank you very much for this PR! Looks good to me and happy to merge. I'll just wait for your reply to my review comment above! 🙂 |
PR:
CI:
test/test_urls.jlbut some fail (as expected)