Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm pkg fix + gitignore #245

Merged
merged 1 commit into from
Aug 7, 2024
Merged

npm pkg fix + gitignore #245

merged 1 commit into from
Aug 7, 2024

Conversation

atoledo
Copy link
Contributor

@atoledo atoledo commented Aug 7, 2024

Description

  • npm pkg fix
  • gitignore to prevent npm configs to be versioned
  • Not worth a release on its own

@atoledo atoledo self-assigned this Aug 7, 2024
@@ -29,7 +29,7 @@
},
"repository": {
"type": "git",
"url": "git@github.com:briza-insurance/illogical.git"
"url": "git+ssh://git@github.com/briza-insurance/illogical.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the new npm version require this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so. NPM already made this change before publishing

@atoledo atoledo merged commit 5e2d663 into master Aug 7, 2024
1 check passed
@rthreei rthreei deleted the pkg-fix branch August 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants