Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create missing atom for XIGetProperty request in fixed_valuator_relative #1834

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Create missing atom for XIGetProperty request in fixed_valuator_relative #1834

merged 1 commit into from
Apr 17, 2024

Conversation

Caellian
Copy link
Collaborator

I'm assuming sending None Atom in the request will cause an error. I defined those properties on my platform so that's why the function didn't fail.

Should close #1833.

Out of scope

  • Updated contributing link in project README.md
  • Added session and desktop printing to reduce back and forth in issues
    • GDM seems to be the only DM that defines session env variable.
  • Replaced fprintf(stderr,... with NORM_ERR in x11.cc

@Caellian
Create missing atom for query
eeda23a 
I'm assuming sending None Atom in the request will cause an error.
I defined those properties on my platform so that's why the function
didn't fail.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian Caellian linked an issue Apr 17, 2024 that may be closed by this pull request
[Bug]: conky-1.20.0 hangs with no output. Debugging shows "X cursor Error". #1833
Closed
@github-actions github-actions bot added the sources PR modifies project sources label Apr 17, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit eeda23a
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6620210d23bc590008cc90c9

@brndnmtthws brndnmtthws added the bug Bug report or bug fix PR label Apr 17, 2024
@Caellian Caellian added display: x11 Issue related to X11 backend mouse events Issue or PR related to mouse events labels Apr 17, 2024
@Caellian Caellian merged commit d815f9a into main Apr 17, 2024
62 checks passed
@Caellian Caellian deleted the fix/relative-valuator-override-missing-atom branch April 17, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brndnmtthws brndnmtthws brndnmtthws approved these changes

Assignees
No one assigned
Labels
bug Bug report or bug fix PR display: x11 Issue related to X11 backend mouse events Issue or PR related to mouse events sources PR modifies project sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: conky-1.20.0 hangs with no output. Debugging shows "X cursor Error".
2 participants
@Caellian @brndnmtthws