Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_COLOUR_NAME_MAP build flag #1880

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

brndnmtthws
Copy link
Owner

You can now specify BUILD_COLOUR_NAME_MAP=OFF to disable building the gperf-based colour map, which also removes the requirement for gperf at build time.

This adds back the colour stub feature removed in #1870, however this time it retains backward compatibility with the previous colour name handling behaviour by default.

You can now specify `BUILD_COLOUR_NAME_MAP=OFF` to disable building the
gperf-based colour map, which also removes the requirement for gperf at
build time.
@brndnmtthws brndnmtthws requested a review from Caellian May 1, 2024 11:16
@github-actions github-actions bot added sources PR modifies project sources dependencies Issue or PR that affects dependencies labels May 1, 2024
Copy link

netlify bot commented May 1, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 50a365d
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/66338371eca37700076e598f

@brndnmtthws brndnmtthws added the feature New feature PR or issue label May 1, 2024
src/colour-names-stub.hh Outdated Show resolved Hide resolved
@brndnmtthws brndnmtthws merged commit 1352c28 into main May 2, 2024
62 checks passed
@brndnmtthws brndnmtthws deleted the build-colour-map-flag branch May 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue or PR that affects dependencies feature New feature PR or issue sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants