Remove _member_access from geometry #1910
Merged
Commits on May 13, 2024
-
Remove _member_access from geometry.
It was difficult ensuring temporary `this` was correct when combined with composition. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
-
Add some convenience setters. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
-
Disable unknown-warning-option lint
This allows source pragmas for future warnings which are in a newer version of the compiler but not implemented in an older one. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
-
Fix "specified bound depends on the length of the source argument"
strncat that concatenates to a buffer whose length was determined from source strlen can be replaced by strcat - if the buffer is invalid (unterminated), using strlen will result in same behavior. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
-
Revert CMake formatter changes
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.