Fix for the graph scale text colour changing depending on graph position #1957
Conversation
… scale, to ensure it always stays the same colour
✅ Deploy Preview for conkyweb canceled.
|
|
Not sure what the Docker issue is, I don't have any experience with Docker. |
There was a problem hiding this comment.
You have approval from me as the change should work and the first_colour is a better choice than the one that fills the rect. And using the first column for coloring is wrong anyway (should be current state?).
There are edge cases with readability still - in case someone uses a gradient that's got similar color stops (e.g. lightness gradient with 40% difference). But the colors might also be similar to last_colour (borders), so there's really no perfect solution that will work in all cases and make everyone happy with how it looks.
Thank you for the contribution, it's a good improvement. Feel free to merge it if you don't plan on making any further modifications.
Checklist
Description
In the current latest code of conky, when you have a graph scale enabled, the text will change colour whenever a "high point" on the graph reached the "end" of the graph. It's difficult to describe so I took some screenshots:
Before
The scale text changes colour to whatever the colour of the leftmost "bar" of the graph is.
After
No longer does this
I'm not sure if this was an intended feature, if it was, feel free to close this. imo it shouldn't change colour because it makes the text very hard to read when the whole graph is full of red.
It's a simple fix, just adding one extra line to change the colour back to the "first" graph colour (i.e. the colour of the lowest values)
There shouldn't be any unintended side effects of the change, because looking at the code, this is the last if statement in a block, and right after the if statements, the colour gets changed anyway (
set_foreground_color(last_colour);)