Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed graph parsing error #1993

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

donutAnees
Copy link
Contributor

@donutAnees donutAnees commented Jul 22, 2024

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • All new code is licensed under GPLv3

Description

Before

In the current version of conky, scan_graph method, parsing doesn't consider the flags and can lead to undesirable changes. The parsing also had issues with resetting some variables after sscanf.

After

The changes made will resolve these issues. The parsing now correctly considers flags, preventing undesirable changes, and ensures that variables are properly reset.

Fixes #1992

@github-actions github-actions bot added sources PR modifies project sources rendering Issue or PR related to rendering text Issue or PR related to `conky.text` variables labels Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit e9e34e7
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/669e8fb807ed57000855fc12

@brndnmtthws brndnmtthws added the bug Bug report or bug fix PR label Jul 23, 2024
Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brndnmtthws brndnmtthws merged commit 2009147 into brndnmtthws:main Jul 23, 2024
39 checks passed
@donutAnees donutAnees deleted the graph_parsing_error branch July 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR rendering Issue or PR related to rendering sources PR modifies project sources text Issue or PR related to `conky.text` variables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Graph configuration parsing error
2 participants