Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1807 Modernize Docker build #338

Merged
merged 3 commits into from
Sep 3, 2024
Merged

WX-1807 Modernize Docker build #338

merged 3 commits into from
Sep 3, 2024

Conversation

aednichols
Copy link
Contributor

@aednichols aednichols commented Sep 3, 2024

In scope:

  • Update Docker runtime to DSP official image for Java 11
    • Main goal of WX-1807 ticket
    • Replaces Ubuntu 20.04 with 22.04
  • Update Docker builder to a modern image from SBT maintainers Cannot due to Jenkins
    • Replaces Ubuntu 14.04 (!) with 22.04
    • Upgrade Scala minor version to match builder
    • Fix minor build issues required for Scala minor version

Out of scope:

  • Upgrade to Java 17

Runtime

Before

> docker run -it --entrypoint /bin/bash adoptopenjdk:11-hotspot
root@c614de33bae8:/# cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.3 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.3 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

After

> docker run -it --entrypoint /bin/bash us.gcr.io/broad-dsp-gcr-public/base/jre:11-debian
root@c453e78a7eab:/# cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Builder

Before

> docker run -it --entrypoint /bin/bash broadinstitute/scala-baseimage
root@7f0b61bf2337:/# cat /etc/os-release
NAME="Ubuntu"
VERSION="14.04.2 LTS, Trusty Tahr"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 14.04.2 LTS"
VERSION_ID="14.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"

After

> docker run -it --entrypoint /bin/bash sbtscala/scala-sbt:eclipse-temurin-jammy-11.0.22_7_1.9.9_2.13.13
root@78c0bb8a8e5e:~# cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

@aednichols aednichols merged commit 524716f into develop Sep 3, 2024
7 checks passed
@aednichols aednichols deleted the aen_wx_1807 branch September 3, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants