add notes

broadinstitute · Sep 20, 2024 · 77deaa0 · 77deaa0
1 parent cccf552
commit 77deaa0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/...e/batch/src/main/scala/cromwell/backend/google/batch/api/GcpBatchRequestFactoryImpl.scala b/...e/batch/src/main/scala/cromwell/backend/google/batch/api/GcpBatchRequestFactoryImpl.scala
@@ -143,6 +143,7 @@ class GcpBatchRequestFactoryImpl()(implicit gcsTransferConfiguration: GcsTransfe
       .putLabels("cromwell-workflow-id", toLabel(data.workflowId.toString)) // label for workflow from WDL
       .putLabels("goog-batch-worker", "true")
       .putAllLabels(data.createParameters.googleLabels.map(label => label.key -> label.value).toMap.asJava)
+      // TODO confirmed Google Compute Service Account is assigned here
       .setServiceAccount(serviceAccount)
       .buildPartial()
 
@@ -169,6 +170,7 @@ class GcpBatchRequestFactoryImpl()(implicit gcsTransferConfiguration: GcsTransfe
 
     // set parent for metadata storage of job information
     lazy val parent = s"projects/${createParameters.projectId}/locations/${data.gcpBatchParameters.region}"
+    // TODO confirmed Google Compute Service Account is correctly plumbed through from workflow options to here
     val gcpSa = ServiceAccount.newBuilder.setEmail(createParameters.computeServiceAccount).build
 
     // make zones path