Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funcotator default values were using single static instances for default values. #4839

Closed
LeeTL1220 opened this issue May 31, 2018 · 0 comments
Assignees

Comments

@LeeTL1220
Copy link
Contributor

This causes integration tests to fail.

@LeeTL1220 LeeTL1220 self-assigned this May 31, 2018
LeeTL1220 added a commit that referenced this issue Jun 8, 2018
#4838)

- Added flag to ease restrictions on b37 reference for chr/non-chr comparisons.  This is useful for dev testing.
- Added parsing of funcotation attribute using the VCF Header.  Mostly used for dev testing.
- VCF Datasources now have to match the alt and ref alleles to be considered a hit.
- Added FuncotationMap to improve encapsulation and make rendering a bit easier.
- Fixed issue with FuncotatorIntegrationTest where default values were references that were changed, thereby causing cross-test errors.
- A lot of refactoring to create FuncotationMap and use that to send to OutputRenderers.
- VCF and MAF will honor the canonical vs. all vs best effect.
- Closes #3842
- Closes #4808
- Closes #4811
- Closes #4810
- Closes #4839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant