Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1R2 and F2R2 annotations not updated by GenotypeGvcfs #5704

Closed
nh13 opened this issue Feb 21, 2019 · 6 comments · Fixed by #5833
Closed

F1R2 and F2R2 annotations not updated by GenotypeGvcfs #5704

nh13 opened this issue Feb 21, 2019 · 6 comments · Fixed by #5833
Assignees

Comments

@nh13
Copy link
Contributor

nh13 commented Feb 21, 2019

The gVCF output of HaplotypeCaller:

... ATTTTTT A,ATT,ATTT,ATTTT,ATTTTT,<NON_REF> ... GT:AD:DP:F1R2:F2R1:GQ:PL:SB	4/5:8,2,5,8,19,17,0:59:5,2,5,8,17,17,0:3,0,0,0,2,0,0:99:841,879,2162,594,1484,1406,395,983,921,881,140,419,309,264,313,382,470,281,174,0,402,828,1443,1223,962,474,507,1363:5,3,49,2

The VCF output of GenotypeGvcfs:

... ATT A,AT ... GT:AD:DP:F1R2:F2R1:GQ:PL ... 1/2:8,19,17:59:5,2,5,8,17,17,0:3,0,0,0,2,0,0:99:841,140,313,382,0,402

In both cases, F1R2 is 5,2,5,8,17,17,0. There are seven alleles in the gVCF but only three in the VCF, so the F1R2 is wrong for the latter.

@ldgauthier
Copy link
Contributor

ldgauthier commented Feb 21, 2019

Traditionally we've only used the OxoGReadCounts annotation for somatic data, which was single-sample until very recently. I'll put a note in the docs and check the GGVCFs FORMAT combine operations.

Implementing an actual combine shouldn't be too hard. Is this a blocking issue for you @nh13 ?

@ldgauthier ldgauthier self-assigned this Feb 21, 2019
@nh13
Copy link
Contributor Author

nh13 commented Feb 21, 2019

@ldgauthier not a blocking issue at all, I just wanted to report it, in case others stumble upon it, and if you had free time to take a look.

@nh13
Copy link
Contributor Author

nh13 commented Mar 12, 2019

@ldgauthier this does block downstream tools, like bcftools from using VCFs with this annotation, for example when subsetting and trimming the alleles.

@ldgauthier
Copy link
Contributor

@nh13 I did get started on this. It works, but needs formal tests. I might be able to finish it up this week, but if your need is urgent and you trust me without tests, then there's a branch.

@nh13
Copy link
Contributor Author

nh13 commented Mar 21, 2019

@ldgauthier will you also be able to fold in the changes in #5698 (comment)

@ldgauthier
Copy link
Contributor

ldgauthier commented Mar 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants