Updated the experimental funcotator.wdl to work properly in cromwell. #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with Cromwell 30.2
LeeTL1220
reviewed
Jun 8, 2018
|
|
||
| String? data_sources_tar_gz | ||
| File? interval_list |
There was a problem hiding this comment.
Need to add a comment up top for interval_list parameter. Make sure to mention that it is optional.
| String? transcript_selection_mode | ||
| Array[String]? transcript_selection_list | ||
| Array[String]? annotation_defaults | ||
| Array[String]? annotation_overrides | ||
| File? gatk4_jar_override | ||
|
|
||
| call MakeItFunky { | ||
| String? funcotator_extra_args |
There was a problem hiding this comment.
Need to add a comment up top for funcotator_extra_args
Codecov Report
@@ Coverage Diff @@
## master #4870 +/- ##
==============================================
+ Coverage 80.42% 80.528% +0.108%
- Complexity 17813 18352 +539
==============================================
Files 1089 1089
Lines 64133 65588 +1455
Branches 10340 10743 +403
==============================================
+ Hits 51576 52817 +1241
- Misses 8499 8649 +150
- Partials 4058 4122 +64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Cromwell 30.2