Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocatableXsv data sources now produce at most 1 funcotation #4936

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

jonn-smith
Copy link
Collaborator

LocatableXsv data sources now produce at most 1 funcotation per allele pair.

Fixes #4929

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. My only question is whether you think #4930 should be a betablocker? Feel free to merge, regardless.

@codecov-io
Copy link

Codecov Report

Merging #4936 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master     #4936   +/-   ##
===========================================
  Coverage     80.456%   80.456%           
  Complexity     17819     17819           
===========================================
  Files           1090      1090           
  Lines          64203     64203           
  Branches       10358     10358           
===========================================
  Hits           51655     51655           
  Misses          8498      8498           
  Partials        4050      4050
Impacted Files Coverage Δ Complexity Δ
...ataSources/xsv/LocatableXsvFuncotationFactory.java 85.185% <ø> (ø) 24 <0> (ø) ⬇️

@jonn-smith jonn-smith merged commit 02f3cf7 into master Jun 21, 2018
@jonn-smith jonn-smith deleted the jts_funcotator_locatableXsv_multiple_hits_4929 branch June 21, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants