Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update publishing for failed tests #5108

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

lbergelson
Copy link
Member

the first commit is the fix, the second is a deliberate test failure so we can validate that the fix works when the tests fail

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be working in all the relevant cases, once you remove that test 👍

@lbergelson lbergelson force-pushed the lb_update_publishing_for_failed_tests branch from e70708c to b2ab880 Compare August 14, 2018 21:36
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #5108 into master will decrease coverage by 44.069%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##              master     #5108        +/-   ##
================================================
- Coverage     86.496%   42.427%   -44.069%     
+ Complexity     29205     17142     -12063     
================================================
  Files           1814      1814                
  Lines         135364    135370         +6     
  Branches       15042     15042                
================================================
- Hits          117084     57433     -59651     
- Misses         12819     73162     +60343     
+ Partials        5461      4775       -686
Impacted Files Coverage Δ Complexity Δ
...hellbender/utils/genotyper/AlleleListUnitTest.java 2.963% <0%> (-90.27%) 2 <0> (-32)
...copynumber/models/AlleleFractionSimulatedData.java 0% <0%> (-100%) 0% <0%> (-11%)
...odecs/gencode/GencodeGtfSelenocysteineFeature.java 0% <0%> (-100%) 0% <0%> (-4%)
...ctions/RequiredFeatureInputArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-1%)
...ools/copynumber/models/CopyRatioSimulatedData.java 0% <0%> (-100%) 0% <0%> (-9%)
...der/tools/walkers/genotyper/afcalc/GetGLsTest.java 0% <0%> (-100%) 0% <0%> (-12%)
...titute/hellbender/utils/UnvalidatingGenomeLoc.java 0% <0%> (-100%) 0% <0%> (-1%)
...ogramgroups/ShortVariantDiscoveryProgramGroup.java 0% <0%> (-100%) 0% <0%> (-3%)
...ecaller/graphs/DeadEndKBestSubHaplotypeFinder.java 0% <0%> (-100%) 0% <0%> (-10%)
...sformers/MisencodedBaseQualityReadTransformer.java 0% <0%> (-100%) 0% <0%> (-4%)
... and 1032 more

@jamesemery jamesemery merged commit b6fba1d into master Aug 15, 2018
@jamesemery jamesemery deleted the lb_update_publishing_for_failed_tests branch August 15, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants