Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify HaplotypeBAMWriter code. #944 #5122

Merged
merged 9 commits into from
Aug 30, 2018
Merged

Simplify HaplotypeBAMWriter code. #944 #5122

merged 9 commits into from
Aug 30, 2018

Commits on Aug 16, 2018

  1. Compressed subclass (SAMFileDestination) into HaplotypeBAMDestination.

    @kvinter1
    kvinter1 committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    464a704 View commit details
    Browse the repository at this point in the history

  2. Work in progress

    @kvinter1
    kvinter1 committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    51315b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Attempt to fix #944.

    @kvinter1
    kvinter1 committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    5cbbce3 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Update HaplotypeBAMDestination.java 

    Deletion of redundant check of sourceReader being nonNull. (same as Line 45)
    @kvinter1
    kvinter1 authored Aug 22, 2018
    Configuration menu
    Copy the full SHA
    3348855 View commit details
    Browse the repository at this point in the history

  2. Fixed some formatting issues

    @kvinter1
    kvinter1 committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    3bc40a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Reverted back to HaplotypeBAMDestination as abstract super and the ex… 

    …istence of SAMFileDestination as its subclass. Kept the consolidation of HaplotypeBAMWriter and its subclasses (AllHaplotypeBAMWriter and CalledHaplotypeBAMWriter).
    @kvinter1
    kvinter1 committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    1ba7de7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. Attempt to fix @cmnbroad 's corrections'

    @kvinter1
    kvinter1 committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    b5fa08f View commit details
    Browse the repository at this point in the history

  2. New changes to comments

    @kvinter1
    kvinter1 committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    222ecc0 View commit details
    Browse the repository at this point in the history

  3. Changes to if statement in HaplotypeBAMWriter

    @kvinter1
    kvinter1 committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    893d557 View commit details
    Browse the repository at this point in the history