Added new catch block for character encoding error cases. #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new catch block in `PathLineIterator` for character encoding errors, along with a new error message to be given to the user for such cases. Added unit test for malformed xsv locatable files. Fixes #4006
Codecov Report
@@ Coverage Diff @@
## master #5124 +/- ##
=============================================
+ Coverage 86.66% 86.66% +<.001%
- Complexity 29043 29048 +5
=============================================
Files 1808 1808
Lines 134662 134686 +24
Branches 14935 14938 +3
=============================================
+ Hits 116698 116719 +21
Misses 12552 12552
- Partials 5412 5415 +3
|
LeeTL1220
reviewed
Aug 20, 2018
There was a problem hiding this comment.
So, if I understand correctly, @jonn-smith , this is simply if there is a character encoding issue in the config file for an xsv locatable datasource/funcotationfactory?
If so, that is fine. Minor comment(s)... feel free to merge after addressed.
| @@ -30,10 +32,14 @@ | |||
| * @param path path to a text file. | |||
| * @throws UserException if we cannot open the file for reading. | |||
| */ | |||
| public PathLineIterator(Path path) throws UserException { | |||
| public PathLineIterator(final Path path) throws UserException { | |||
There was a problem hiding this comment.
Do we need throws UserException, since that is a runtime exception?
There was a problem hiding this comment.
It does not. I'll pull it out.
|
That's correct. I ran into a character encoding issue with a test file at one point. This will make the errors a little more explanatory. |
jonn-smith
deleted the
jts_funcotator_xsv_encoding_error_fix_4006_ATTEMPT_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new catch block in
PathLineIteratorfor character encodingerrors, along with a new error message to be given to the user for such
cases.
Added unit test for malformed xsv locatable files.
Fixes #4006