Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funcotation Engine Refactoring #5134

Merged
merged 4 commits into from
Sep 19, 2018
Merged

Funcotation Engine Refactoring #5134

merged 4 commits into from
Sep 19, 2018

Commits on Sep 13, 2018

  1. Extraced a FuncotatorEngine from Funcotator.java 

    A large refactoring of the architecture of Funcotator to make the
creation of annotations separate from the command line interface.

This will enable better testing of the annotation functionality by
allowing for unit tests that can test the created funcotations directly
(as opposed to requiring integration tests for the same purpose).
    @LeeTL1220 @jonn-smith
    LeeTL1220 authored and jonn-smith committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    b822fc5 View commit details
    Browse the repository at this point in the history

  2. Fixing a small error made in the rebasing onto master.

    @jonn-smith
    jonn-smith committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5a3b039 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Finished addressing @droazen comments, but there are problems.

    @jonn-smith
    jonn-smith committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    ed1fff6 View commit details
    Browse the repository at this point in the history

  2. Finished addressing code review comments.

    @jonn-smith
    jonn-smith committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    c6957b0 View commit details
    Browse the repository at this point in the history