Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-java: update to the official 0.59.0 release, and move off of our custom fork #5135

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

droazen
Copy link
Collaborator

@droazen droazen commented Aug 24, 2018

The google-cloud-java maintainers have merged a fix for the longstanding issue
googleapis/google-cloud-java#2453 that prevented us
from running on a modern version of the library, and forced us to run off of a fork.
This PR updates us to the latest release, which incorporates the fix.

Resolves #3591
Resolves #3500
Resolves #4986

…f of our custom fork

The google-cloud-java maintainers have merged a fix for the longstanding issue
googleapis/google-cloud-java#2453 that prevented us
from running on a modern version of the library, and forced us to run off of a fork.
This PR updates us to the latest release, which incorporates the fix.

Resolves #3591
Resolves #3500
Resolves #4986
@droazen droazen force-pushed the dr_upgrade_to_google-cloud-java_0.59.0 branch from 566cde1 to 8da197e Compare August 24, 2018 20:06
@droazen
Copy link
Collaborator Author

droazen commented Aug 24, 2018

Confirmed that 0.59.0 fixes #3591, whereas 0.58.0 failed the same test case.

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an info field printout somewhere indicating to the user which version of this dependency they are running with like we do for Picard etc... That can probably be in a separate PR though. This branch looks good 👍

@droazen droazen self-assigned this Aug 24, 2018
@droazen droazen merged commit 43750e9 into master Aug 24, 2018
@droazen droazen deleted the dr_upgrade_to_google-cloud-java_0.59.0 branch August 24, 2018 21:06
@codecov-io
Copy link

Codecov Report

Merging #5135 into master will increase coverage by 0.007%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##              master    #5135       +/-   ##
==============================================
+ Coverage     86.653%   86.66%   +0.007%     
- Complexity     29061    29064        +3     
==============================================
  Files           1809     1809               
  Lines         134751   134750        -1     
  Branches       14935    14935               
==============================================
+ Hits          116766   116774        +8     
+ Misses         12572    12564        -8     
+ Partials        5413     5412        -1
Impacted Files Coverage Δ Complexity Δ
...stitute/hellbender/cmdline/CommandLineProgram.java 83.893% <ø> (-0.107%) 43 <0> (ø)
...nder/utils/runtime/StreamingProcessController.java 72.249% <0%> (+0.957%) 36% <0%> (+1%) ⬆️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants