fixing pom issues that prevented publishing #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lbergelson
commented
Sep 25, 2018
lbergelson
commented
- fixing two issues that prevented us from publishing to maven central
- fixing sourceJar typo -> sourcesJar
- configure the pom for all artifact filters
- partial fix for Fix maven release and perform manual release of 4.0.9.0 #5212
|
I'm not sure if there's a cleaner way to specify the pom without having to set it in so many places. If anyone has a good suggestion let me know... |
2 tasks
cmnbroad
reviewed
Sep 25, 2018
| baseName = "$project.name-test-utils" | ||
| classifier = 'source' | ||
| classifier = 'sources' |
There was a problem hiding this comment.
Wow - was this just silently not working ?
There was a problem hiding this comment.
It was loudly not working when we tried to do a maven release.
| args.addOutput(new File("out.vcf")); | ||
|
|
||
| runCommandLine(args); | ||
| } |
There was a problem hiding this comment.
Assuming inclusion of this test is an oversight ?
There was a problem hiding this comment.
Ack, yes, that is definitely an oversight...
cmnbroad
approved these changes
Sep 25, 2018
* fixing two issues that prevented us from publishing to maven central - fixing sourceJar typo -> sourcesJar - configure the pom for all artifact filters * partial fix for #5212
lbergelson
force-pushed
the
lb_fix_maven_publishing
branch
from
0be61d3
to
933970c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.